check agent cg after goal state processed and handle extensions to starts in extension slice #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagworld9
requested review from
narrieta,
larohra,
kevinclark19a,
ZhidongPeng and
dhivyaganesan
as code owners
nagworld9
commented
Apr 12, 2022
| if self.is_azuremonitorlinuxagent(self.get_full_name()) and \ | ||
| not CGroupConfigurator.get_instance().is_extension_resource_limits_setup_completed(self.get_full_name()): | ||
| # This check to call the setup if extension already installed and not called setup before | ||
| if not CGroupConfigurator.get_instance().is_extension_resource_limits_setup_completed(self.get_full_name()): |
There was a problem hiding this comment.
we used to do it for only AMA but this setup needed for every extension to starts in VMExtension slice.
Codecov Report
@@ Coverage Diff @@
## develop #2546 +/- ##
===========================================
+ Coverage 71.76% 71.79% +0.03%
===========================================
Files 102 102
Lines 15314 15321 +7
Branches 2426 2429 +3
===========================================
+ Hits 10990 11000 +10
+ Misses 3834 3829 -5
- Partials 490 492 +2
Continue to review full report at Codecov.
|
nagworld9
changed the title
narrieta
reviewed
Apr 13, 2022
| @@ -540,7 +540,7 @@ def __try_set_cpu_quota(quota): | |||
| return False | |||
| return True | |||
|
|
|||
| def check_cgroups(self, cgroup_metrics): | |||
| def check_cgroups(self, cgroup_metrics=None): | |||
There was a problem hiding this comment.
None is not a good default value. Maybe a list of values, or an enum?
azurelinuxagent/ga/update.py
Outdated
| @@ -614,6 +614,10 @@ def _process_goal_state(self, exthandlers_handler, remote_access_handler): | |||
| self._extensions_summary = ExtensionsSummary() | |||
| exthandlers_handler.run() | |||
|
|
|||
| # check cgroup and disable if any extension started in agent cgroup after goal state processed. | |||
| # Note: Monitor thread periodically checks this in addition to here. | |||
| CGroupConfigurator.get_instance().check_cgroups() | |||
There was a problem hiding this comment.
since now this is called from 2 threads, please verify the method is thread-safe or add a lock
narrieta
reviewed
Apr 15, 2022
| @@ -131,6 +132,7 @@ def __init__(self): | |||
| self._cgroups_api = None | |||
| self._agent_cpu_cgroup_path = None | |||
| self._agent_memory_cgroup_path = None | |||
| self._lock = threading.RLock() | |||
There was a problem hiding this comment.
can we rename this to help document what the lock is meant to be used for?
_check_cgroups_lock?
narrieta
previously approved these changes
Apr 15, 2022
nagworld9
force-pushed
the
agent-cg-check
branch
from
13d1dda
to
9c490c4
Compare
narrieta
approved these changes
Apr 15, 2022
kevinclark19a
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #
PR information
Quality of Code and Contribution Guidelines